Update regis.get_layer_names() to return pre 2.2.3 names#433
Merged
Conversation
If regis version would receive a small version bump, the origional code would crash. With the proposed changes less likely so.
Collaborator
Author
|
The failed test is unrelated to the changes proposed here. They are related to a firewall at nhi.nu. url = 'https://gwo.nhi.nu/api/v1/well_filters/', page = 1, properties = []
params = {'format': 'csv', 'n_well_filters': 1000, 'page': 1, 'well__organization': 'Brabant Water'}
r = <Response [403]>
content = '<!DOCTYPE html>\r\n<html>\r\n<head>\r\n <title>Web App - Unavailable</title>\r\n <style type="text/css">\r\n ...app you have attempted to reach has blocked your access.</p>\r\n </div>\r\n </div>\r\n</body>\r\n</html>\r\n' |
rubencalje
requested changes
Mar 26, 2025
Collaborator
rubencalje
left a comment
rubencalje
left a comment
There was a problem hiding this comment.
Great addition! I have one request to make it a bit more robust.
…d streamline layer name assignment in get_regis function.
Collaborator
Author
|
Failing tests are not related again with the changes made here |
rubencalje
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#432